From dd678ac323b81e67bb1dea488f2123efee7e3500 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 1 Dec 2010 23:32:35 -0500 Subject: [PATCH] Avoid a warning when finalizing toolbars Recent changes cause disposing menus to emit ::deactivate. So better disconnect the deactivate handler first. --- gtk/gtktoolbar.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gtk/gtktoolbar.c b/gtk/gtktoolbar.c index 007d039467..5d914fada4 100644 --- a/gtk/gtktoolbar.c +++ b/gtk/gtktoolbar.c @@ -3125,8 +3125,12 @@ gtk_toolbar_finalize (GObject *object) g_timer_destroy (priv->timer); if (priv->menu) - gtk_widget_destroy (GTK_WIDGET (priv->menu)); - + { + g_signal_handlers_disconnect_by_func (priv->menu, + menu_deactivated, toolbar); + gtk_widget_destroy (GTK_WIDGET (priv->menu)); + } + if (priv->idle_id) g_source_remove (priv->idle_id); -- 2.30.2